[PATCH v7 4/5] media: platform: mediatek: isp: add mediatek ISP3.0 camsv

[CK Hu (胡俊光)]

Hi, Julien:

On Thu, 2024-11-21 at 09:53 +0100, Julien Stephan wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> From: Phi-bang Nguyen <pnguyen at baylibre.com>
> 
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
> 
> Signed-off-by: Phi-bang Nguyen <pnguyen at baylibre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Co-developed-by: Julien Stephan <jstephan at baylibre.com>
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---

[snip]

> +static const u32 mtk_cam_mbus_formats[] = {
> +       MEDIA_BUS_FMT_SBGGR8_1X8,
> +       MEDIA_BUS_FMT_SGBRG8_1X8,
> +       MEDIA_BUS_FMT_SGRBG8_1X8,
> +       MEDIA_BUS_FMT_SRGGB8_1X8,
> +       MEDIA_BUS_FMT_SBGGR10_1X10,
> +       MEDIA_BUS_FMT_SGBRG10_1X10,
> +       MEDIA_BUS_FMT_SGRBG10_1X10,
> +       MEDIA_BUS_FMT_SRGGB10_1X10,
> +       MEDIA_BUS_FMT_SBGGR12_1X12,
> +       MEDIA_BUS_FMT_SGBRG12_1X12,
> +       MEDIA_BUS_FMT_SGRBG12_1X12,
> +       MEDIA_BUS_FMT_SRGGB12_1X12,
> +       MEDIA_BUS_FMT_UYVY8_1X16,
> +       MEDIA_BUS_FMT_VYUY8_1X16,
> +       MEDIA_BUS_FMT_YUYV8_1X16,
> +       MEDIA_BUS_FMT_YVYU8_1X16,
> +};
> +

Format in mtk_cam_mbus_formats[] is more than mtk_cam_format_info[].
I would like these two to be consistent.
Reduce mtk_cam_mbus_formats[] or enlarge mtk_cam_format_info[].
Once these two are consistent, they could be merged into one array.

Regards,
CK

> +static const struct mtk_cam_format_info mtk_cam_format_info[] = {
> +       {
> +               .fourcc = V4L2_PIX_FMT_SBGGR8,
> +               .code = MEDIA_BUS_FMT_SBGGR8_1X8,
> +               .bpp = 8,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_SGBRG8,
> +               .code = MEDIA_BUS_FMT_SGBRG8_1X8,
> +               .bpp = 8,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_SGRBG8,
> +               .code = MEDIA_BUS_FMT_SGRBG8_1X8,
> +               .bpp = 8,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_SRGGB8,
> +               .code = MEDIA_BUS_FMT_SRGGB8_1X8,
> +               .bpp = 8,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_YUYV,
> +               .code = MEDIA_BUS_FMT_YUYV8_1X16,
> +               .bpp = 16,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_YVYU,
> +               .code = MEDIA_BUS_FMT_YVYU8_1X16,
> +               .bpp = 16,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_UYVY,
> +               .code = MEDIA_BUS_FMT_UYVY8_1X16,
> +               .bpp = 16,
> +       }, {
> +               .fourcc = V4L2_PIX_FMT_VYUY,
> +               .code = MEDIA_BUS_FMT_VYUY8_1X16,
> +               .bpp = 16,
> +       },
> +};
> +

>