[PATCH v7 4/5] media: platform: mediatek: isp: add mediatek ISP3.0 camsv

[CK Hu (胡俊光)]

Hi, Julien:

On Thu, 2024-11-21 at 09:53 +0100, Julien Stephan wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> From: Phi-bang Nguyen <pnguyen at baylibre.com>
> 
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
> 
> Signed-off-by: Phi-bang Nguyen <pnguyen at baylibre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Co-developed-by: Julien Stephan <jstephan at baylibre.com>
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---

[snip]

> +static void mtk_cam_vb2_buf_queue(struct vb2_buffer *vb)
> +{
> +       struct mtk_cam_dev *cam = vb2_get_drv_priv(vb->vb2_queue);
> +       struct mtk_cam_dev_buffer *buf = to_mtk_cam_dev_buffer(vb);
> +       unsigned long flags;
> +
> +       /* Add the buffer into the tracking list */
> +       spin_lock_irqsave(&cam->buf_list_lock, flags);
> +       if (list_empty(&cam->buf_list))
> +               (*cam->hw_functions->mtk_cam_update_buffers_add)(cam, buf);
> +
> +       list_add_tail(&buf->list, &cam->buf_list);
> +       (*cam->hw_functions->mtk_cam_fbc_inc)(cam);

I think fbc_inc should together with update_buffers_add.
After update_buffers_add then fbc_inc.
So squash fbc_inc into update_buffers_add and drop fbc_inc function.

Regards,
CK

> +       spin_unlock_irqrestore(&cam->buf_list_lock, flags);
> +}
> +

>