[PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

CK Hu (胡俊光) ck.hu at mediatek.com
Tue Nov 19 00:29:47 PST 2024


Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang at mediatek.com>
> ---

[snip]

> +/* For LBIT_MODE G2 */
> +enum mtkcam_ipi_sw_feature_control {
> +	MTKCAM_IPI_SW_FEATURE_NORMAL		= 0,
> +	/* Normal */
> +};
> +

[snip]

> +struct mtkcam_ipi_config_param {
> +	u8	flags;
> +	struct mtkcam_ipi_input_param	input;
> +	u8	n_maps;
> +	/* maximum # of pipes per stream */
> +	struct mtkcam_ipi_hw_mapping maps[6];
> +	/* sub_ratio:8, valid number: 8 */
> +	u16	valid_numbers[MTKCAM_IPI_FBCX_LAST];
> +	u8	sw_feature;

Only one sw_feature (MTKCAM_IPI_SW_FEATURE_NORMAL). So it's not necessary to pass this information to scp.
Drop this and MTKCAM_IPI_SW_FEATURE_NORMAL.

Regards,
CK

> +} __packed;
> +



More information about the Linux-mediatek mailing list