Aw: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988

[Frank Wunderlich]

> Gesendet: Montag, 11. November 2024 um 21:38
> Von: "Rob Herring" <robh at kernel.org>
> An: "Frank Wunderlich" <linux at fw-web.de>
> CC: "Mark Brown" <broonie at kernel.org>, "Krzysztof Kozlowski" <krzk+dt at kernel.org>, "Conor Dooley" <conor+dt at kernel.org>, "Matthias Brugger" <matthias.bgg at gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>, "Frank Wunderlich" <frank-w at public-files.de>, "Leilk Liu" <leilk.liu at mediatek.com>, linux-spi at vger.kernel.org, devicetree at vger.kernel.org, linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-mediatek at lists.infradead.org
> Betreff: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
>
> On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w at public-files.de>
> >
> > MT7988 has 2 different spi controllers. Add their compatibles.
> >
> > Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> > ---
> >  Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > index e1f5bfa4433c..ed17815263a8 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> > @@ -35,6 +35,8 @@ properties:
> >            - enum:
> >                - mediatek,mt7981-spi-ipm
> >                - mediatek,mt7986-spi-ipm
> > +              - mediatek,mt7988-spi-quad
> > +              - mediatek,mt7988-spi-single
> >                - mediatek,mt8188-spi-ipm
> >            - const: mediatek,spi-ipm
>
> Does the fallback make sense for both? Is there some common subset of
> functionality where they are the same?

currently they work only with the fallback compatible, but we see in SDK that there are 2 types...in SDK non-soc specific compatibles are used which was rejected last time.

> Rob
> </frank-w at public-files.de></frank-w at public-files.de></leilk.liu at mediatek.com></frank-w at public-files.de></angelogioacchino.delregno at collabora.com></matthias.bgg at gmail.com></conor+dt at kernel.org></krzk+dt at kernel.org></broonie at kernel.org></linux at fw-web.de></robh at kernel.org>