[PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv

Lee Jones lee at kernel.org
Thu May 2 10:14:51 PDT 2024


On Mon, 29 Apr 2024, Christophe JAILLET wrote:

> Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit :
> > Il 28/04/24 20:27, Christophe JAILLET ha scritto:
> > > In "struct mt6370_priv", the 'reg_cfgs' field is unused.
> > > 
> > > Moreover the "struct reg_cfg" is defined nowhere. Neither in this
> > > file, nor
> > > in a global .h file, so it is completely pointless.
> > > 
> > > Remove it.
> > 
> > Sure
> > 
> > > 
> > > Found with cppcheck, unusedStructMember.
> > > 
> > > So, remove it.
> > 
> > Again?! :-P
> 
> Yes. This way we safe twice the memory space :).

I changed all of the commit messages in this disjointed set to flow a
little better.  No need for a Fixes tag either I feel.

-- 
Lee Jones [李琼斯]



More information about the Linux-mediatek mailing list