[PATCH] wifi: mt76: mt7925: ensure 4-byte alignment for suspend & wow command
Lorenzo Bianconi
lorenzo at kernel.org
Thu Mar 7 03:17:25 PST 2024
> From: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
>
> Before sending suspend & wow command to FW, its length should be
> 4-bytes alignd.
>
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 1 +
> drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> index af0c2b2aacb0..ef29d093f9c3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> @@ -2527,6 +2527,7 @@ int mt76_connac_mcu_set_hif_suspend(struct mt76_dev *dev, bool suspend)
> __le16 tag;
> __le16 len;
> u8 suspend;
> + u8 pad[7];
mt76_connac_mcu_set_hif_suspend() is used even by other drv (e.g. mt7615). Is
this change backward compatible?
Regards,
Lorenzo
> } __packed hif_suspend;
> } req = {
> .hif_suspend = {
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> index 2a0bbfe7bfa5..b8315a89f4a9 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> @@ -535,7 +535,7 @@ struct mt7925_wow_pattern_tlv {
> u8 offset;
> u8 mask[MT76_CONNAC_WOW_MASK_MAX_LEN];
> u8 pattern[MT76_CONNAC_WOW_PATTEN_MAX_LEN];
> - u8 rsv[4];
> + u8 rsv[7];
> } __packed;
>
> static inline enum connac3_mcu_cipher_type
> --
> 2.18.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20240307/34073025/attachment.sig>
More information about the Linux-mediatek
mailing list