[PATCH 37/47] wifi: mt76: mt762x: extend mt76_connac_mcu_sta_basic_tlv for per-link STA

Felix Fietkau nbd at nbd.name
Mon Jun 24 10:44:08 PDT 2024


On 13.06.24 05:02, sean.wang at kernel.org wrote:
> From: Sean Wang <sean.wang at mediatek.com>
> 
> Extend mt76_connac_mcu_sta_basic_tlv with the per-link STA configuration.
> 
> The patch we created is a prerequisite to enable the MLO function in the
> driver. It is purely a refactoring patch so the functionality should
> remain unchanged.
> 
> Co-developed-by: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh at mediatek.com>
> Co-developed-by: Deren Wu <deren.wu at mediatek.com>
> Signed-off-by: Deren Wu <deren.wu at mediatek.com>
> Signed-off-by: Sean Wang <sean.wang at mediatek.com>

This patch is broken on non-mt762x drivers, because the functions that 
call mt76_connac_mcu_sta_basic_tlv may be called with sta == NULL.

I've seen it crash on mt7996 because of that, but mt7915 and mt7615 are 
likely equally affected.

- Felix




More information about the Linux-mediatek mailing list