[PATCH net-next v7 2/5] net: phy: mediatek: Move LED and read/write page helper functions into mtk phy lib

[SkyLake Huang (黃啟澤)]

On Tue, 2024-06-18 at 08:21 -0700, Jakub Kicinski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, 13 Jun 2024 18:40:20 +0800 Sky Huang wrote:
> > This patch moves mtk-ge-soc.c's LED code into mtk phy lib. We
> > can use those helper functions in mtk-ge.c as well. That is to
> > say, we have almost the same HW LED controller design in
> > mt7530/mt7531/mt7981/mt7988's Giga ethernet phy.
> > 
> > Also integrate read/write pages into one helper function. They
> > are basically the same.
> 
> Could you please split this into multiple patches? maybe:
>  - change the line wrapping
>  - integrate read/write pages into one helper 
>  - create mtk-phy-lib.c and mtk.h (pure code move)
>  - add support for LEDs to the other SoC

Hi Jakub,
  Mmm...Sorry. But is this really necessary? I already did similar
things in v2. IMHO, current patchset is small enough for reviewing. You
can easily tell that which parts come from original mediatek-ge.c &
mediatek-ge-soc.c and which part is used for MT7988's mtk-2p5ge.c

BRs,
Sky