[PATCH v4 00/15] genirq/msi: Silence set affinity failed warning

Manivannan Sadhasivam manivannan.sadhasivam at linaro.org
Wed Jul 24 06:50:20 PDT 2024


On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote:
> Various PCIe controllers that mux MSIs onto single IRQ line produce these
> "IRQ%d: set affinity failed" warnings when entering suspend. Remove the
> .irq_set_affinity callbacks and make sure they are NULL in all affected
> controllers, so this warning in kernel/irq/msi.c is not triggered.
> 
> This has been compile-tested only on all but the R-Car PCI controller.
> 
> The clean ups are done per-driver so they can be easily reverted in case
> they break something.
> 

Whole series looks good to me (PCI controller specific patches).

FWIW,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>

- Mani

> Marek Vasut (15):
>   genirq/msi: Silence set affinity failed warning
>   PCI: aardvark: Silence set affinity failed warning
>   PCI: altera-msi: Silence set affinity failed warning
>   PCI: brcmstb: Silence set affinity failed warning
>   PCI: dwc: Silence set affinity failed warning
>   PCI: mediatek-gen3: Silence set affinity failed warning
>   PCI: mediatek: Silence set affinity failed warning
>   PCI: mobiveil: Silence set affinity failed warning
>   PCI: plda: Silence set affinity failed warning
>   PCI: rcar-host: Silence set affinity failed warning
>   PCI: tegra: Silence set affinity failed warning
>   PCI: vmd: Silence set affinity failed warning
>   PCI: xilinx-nwl: Silence set affinity failed warning
>   PCI: xilinx-xdma: Silence set affinity failed warning
>   PCI: xilinx: Silence set affinity failed warning
> 
>  drivers/pci/controller/dwc/pci-keystone.c           |  7 -------
>  drivers/pci/controller/dwc/pcie-designware-host.c   | 12 +++---------
>  .../pci/controller/mobiveil/pcie-mobiveil-host.c    | 11 ++---------
>  drivers/pci/controller/pci-aardvark.c               | 10 ++--------
>  drivers/pci/controller/pci-tegra.c                  | 10 ++--------
>  drivers/pci/controller/pcie-altera-msi.c            | 11 ++---------
>  drivers/pci/controller/pcie-brcmstb.c               | 11 ++---------
>  drivers/pci/controller/pcie-mediatek-gen3.c         | 13 +++----------
>  drivers/pci/controller/pcie-mediatek.c              | 11 ++---------
>  drivers/pci/controller/pcie-rcar-host.c             | 10 ++--------
>  drivers/pci/controller/pcie-xilinx-dma-pl.c         | 11 ++---------
>  drivers/pci/controller/pcie-xilinx-nwl.c            | 11 ++---------
>  drivers/pci/controller/pcie-xilinx.c                |  9 ++-------
>  drivers/pci/controller/plda/pcie-plda-host.c        | 11 ++---------
>  drivers/pci/controller/vmd.c                        | 13 +------------
>  include/linux/msi.h                                 |  2 ++
>  kernel/irq/msi.c                                    |  2 +-
>  17 files changed, 32 insertions(+), 133 deletions(-)
> 
> Cc: "Krzysztof Wilczyński" <kw at linux.com>
> Cc: "Pali Rohár" <pali at kernel.org>
> Cc: "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de>
> Cc: Aleksandr Mishin <amishin at t-argos.ru>
> Cc: Anna-Maria Behnsen <anna-maria at linutronix.de>
> Cc: Anup Patel <apatel at ventanamicro.com>
> Cc: Bjorn Helgaas <bhelgaas at google.com>
> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list at broadcom.com>
> Cc: Daire McNamara <daire.mcnamara at microchip.com>
> Cc: Damien Le Moal <dlemoal at kernel.org>
> Cc: Florian Fainelli <florian.fainelli at broadcom.com>
> Cc: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> Cc: Jianjun Wang <jianjun.wang at mediatek.com>
> Cc: Jim Quinlan <jim2101024 at gmail.com>
> Cc: Jingoo Han <jingoohan1 at gmail.com>
> Cc: Jisheng Zhang <Jisheng.Zhang at synaptics.com>
> Cc: Jon Hunter <jonathanh at nvidia.com>
> Cc: Jonathan Derrick <jonathan.derrick at linux.dev>
> Cc: Jonathan Hunter <jonathanh at nvidia.com>
> Cc: Joyce Ooi <joyce.ooi at intel.com>
> Cc: Karthikeyan Mitran <m.karthikeyan at mobiveil.co.in>
> Cc: Kishon Vijay Abraham I <kishon at kernel.org>
> Cc: Koichiro Den <den at valinux.co.jp>
> Cc: Lorenzo Pieralisi <lpieralisi at kernel.org>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> Cc: Marc Zyngier <maz at kernel.org>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Nicolas Saenz Julienne <nsaenz at kernel.org>
> Cc: Niklas Cassel <cassel at kernel.org>
> Cc: Nipun Gupta <nipun.gupta at amd.com>
> Cc: Nirmal Patel <nirmal.patel at linux.intel.com>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Ryder Lee <ryder.lee at mediatek.com>
> Cc: Shivamurthy Shastri <shivamurthy.shastri at linutronix.de>
> Cc: Siddharth Vadapalli <s-vadapalli at ti.com>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-mediatek at lists.infradead.org
> Cc: linux-pci at vger.kernel.org
> Cc: linux-renesas-soc at vger.kernel.org
> Cc: linux-rpi-kernel at lists.infradead.org
> Cc: linux-tegra at vger.kernel.org
> 
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்



More information about the Linux-mediatek mailing list