[PATCH v4 11/15] PCI: tegra: Silence set affinity failed warning

Marek Vasut marek.vasut+renesas at mailbox.org
Tue Jul 23 06:27:11 PDT 2024


Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset
and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without
printing "IRQ...: set affinity failed(-22)" warning.

Remove .irq_set_affinity implementation which only return -EINVAL from this
controller driver.

Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
---
Cc: "Krzysztof Wilczyński" <kw at linux.com>
Cc: "Pali Rohár" <pali at kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig at pengutronix.de>
Cc: Aleksandr Mishin <amishin at t-argos.ru>
Cc: Anna-Maria Behnsen <anna-maria at linutronix.de>
Cc: Anup Patel <apatel at ventanamicro.com>
Cc: Bjorn Helgaas <bhelgaas at google.com>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list at broadcom.com>
Cc: Daire McNamara <daire.mcnamara at microchip.com>
Cc: Damien Le Moal <dlemoal at kernel.org>
Cc: Florian Fainelli <florian.fainelli at broadcom.com>
Cc: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
Cc: Jianjun Wang <jianjun.wang at mediatek.com>
Cc: Jim Quinlan <jim2101024 at gmail.com>
Cc: Jingoo Han <jingoohan1 at gmail.com>
Cc: Jisheng Zhang <Jisheng.Zhang at synaptics.com>
Cc: Jon Hunter <jonathanh at nvidia.com>
Cc: Jonathan Derrick <jonathan.derrick at linux.dev>
Cc: Jonathan Hunter <jonathanh at nvidia.com>
Cc: Joyce Ooi <joyce.ooi at intel.com>
Cc: Karthikeyan Mitran <m.karthikeyan at mobiveil.co.in>
Cc: Kishon Vijay Abraham I <kishon at kernel.org>
Cc: Koichiro Den <den at valinux.co.jp>
Cc: Lorenzo Pieralisi <lpieralisi at kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
Cc: Marc Zyngier <maz at kernel.org>
Cc: Michal Simek <michal.simek at amd.com>
Cc: Nicolas Saenz Julienne <nsaenz at kernel.org>
Cc: Niklas Cassel <cassel at kernel.org>
Cc: Nipun Gupta <nipun.gupta at amd.com>
Cc: Nirmal Patel <nirmal.patel at linux.intel.com>
Cc: Rob Herring <robh at kernel.org>
Cc: Ryder Lee <ryder.lee at mediatek.com>
Cc: Shivamurthy Shastri <shivamurthy.shastri at linutronix.de>
Cc: Siddharth Vadapalli <s-vadapalli at ti.com>
Cc: Thierry Reding <thierry.reding at gmail.com>
Cc: Thomas Gleixner <tglx at linutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-pci at vger.kernel.org
Cc: linux-renesas-soc at vger.kernel.org
Cc: linux-rpi-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
V3: - New patch
V4: No change
---
 drivers/pci/controller/pci-tegra.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 038d974a318ea..d7517c3976e7f 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -1629,11 +1629,6 @@ static void tegra_msi_irq_unmask(struct irq_data *d)
 	spin_unlock_irqrestore(&msi->mask_lock, flags);
 }
 
-static int tegra_msi_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
-{
-	return -EINVAL;
-}
-
 static void tegra_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
 {
 	struct tegra_msi *msi = irq_data_get_irq_chip_data(data);
@@ -1648,7 +1643,6 @@ static struct irq_chip tegra_msi_bottom_chip = {
 	.irq_ack		= tegra_msi_irq_ack,
 	.irq_mask		= tegra_msi_irq_mask,
 	.irq_unmask		= tegra_msi_irq_unmask,
-	.irq_set_affinity 	= tegra_msi_set_affinity,
 	.irq_compose_msi_msg	= tegra_compose_msi_msg,
 };
 
@@ -1697,8 +1691,8 @@ static const struct irq_domain_ops tegra_msi_domain_ops = {
 };
 
 static struct msi_domain_info tegra_msi_info = {
-	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-		   MSI_FLAG_PCI_MSIX),
+	.flags	= MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+		  MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
 	.chip	= &tegra_msi_top_chip,
 };
 
-- 
2.43.0




More information about the Linux-mediatek mailing list