[PATCH v5 3/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface

CK Hu (胡俊光) ck.hu at mediatek.com
Wed Jul 17 19:36:38 PDT 2024


Hi, Julien:

On Thu, 2024-07-04 at 15:36 +0200, Julien Stephan wrote:
>  	 
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>  From: Louis Kuo <louis.kuo at mediatek.com>
> 
> This will add the mediatek ISP3.0 seninf (sensor interface) driver found
> on several Mediatek SoCs such as the mt8365.
> 
> Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they
> may not be all connected.
> 
> Signed-off-by: Louis Kuo <louis.kuo at mediatek.com>
> Signed-off-by: Phi-bang Nguyen <pnguyen at baylibre.com>
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Co-developed-by: Julien Stephan <jstephan at baylibre.com>
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---
>  MAINTAINERS                                        |    1 +
>  drivers/media/platform/mediatek/Kconfig            |    1 +
>  drivers/media/platform/mediatek/Makefile           |    1 +
>  drivers/media/platform/mediatek/isp/Kconfig        |    2 +
>  drivers/media/platform/mediatek/isp/Makefile       |    3 +
>  drivers/media/platform/mediatek/isp/isp_30/Kconfig |   16 +
>  .../media/platform/mediatek/isp/isp_30/Makefile    |    3 +
>  .../platform/mediatek/isp/isp_30/seninf/Makefile   |    5 +
>  .../mediatek/isp/isp_30/seninf/mtk_seninf.c        | 1576 ++++++++++++++++++++
>  .../mediatek/isp/isp_30/seninf/mtk_seninf_reg.h    |  117 ++

I think you could put mtk_seninf.c and mtk_seninf_reg.h in
drivers/media/platform/mediatek/isp. The seninf driver has only two
files, so it's not necessary to create a folder 'seninf' for only two
files. And for isp_30, we have no any information how many difference
with other isp_xx, for example isp_40, if seninf driver in isp_30 and
in isp_40 has only 10% difference, it's not necessary to duplicate the
90% common code in different folder. So initially, just place the
seninf driver in mediatek/isp folder. When other SoC seninf driver
upstream, we would have enough information to decide to generate new
file or new folder for new SoC.

Regards,
CK



More information about the Linux-mediatek mailing list