Aw: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

[Frank Wunderlich]

Hi,

i can confirm that daniels patch pointed by arinc fixes driver for the wrong devicetree on BPI-R64.

but there are concerns from the netdev/dsa maintainers in its current state

https://patchwork.kernel.org/project/linux-mediatek/patch/11f5f127d0350e72569c36f9060b6e642dfaddbb.1714514208.git.daniel@makrotopia.org/

regards Frank


> Gesendet: Montag, 01. Juli 2024 um 08:16 Uhr
> Von: "Linux regression tracking (Thorsten Leemhuis)" <regressions at leemhuis.info>
> An: "Paolo Abeni" <pabeni at redhat.com>, "David S. Miller" <davem at davemloft.net>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>, "Jakub Kicinski" <kuba at kernel.org>
> Cc: devicetree at vger.kernel.org, linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-mediatek at lists.infradead.org, "Daniel Golle" <daniel at makrotopia.org>, frank-w at public-files.de, "Frank Wunderlich" <linux at fw-web.de>, "Arınç ÜNAL" <arinc.unal at arinc9.com>, "Rob Herring" <robh at kernel.org>, "Conor Dooley" <conor+dt at kernel.org>, "Krzysztof Kozlowski" <krzk+dt at kernel.org>, "Matthias Brugger" <matthias.bgg at gmail.com>, "Linux regressions mailing list" <regressions at lists.linux.dev>
> Betreff: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
>
> [CCing the other net maintainers]
> 
> On 25.06.24 10:51, AngeloGioacchino Del Regno wrote:
> > Il 25/06/24 07:56, Linux regression tracking (Thorsten Leemhuis) ha
> > scritto:
> >> On 17.06.24 13:08, Arınç ÜNAL wrote:
> >>> On 17/06/2024 11:33, Linux regression tracking (Thorsten Leemhuis)
> >>> wrote:
> >>> [...]
> >> It looks more and more like we are stuck here (or was there progress and
> >> I just missed it?) while the 6.10 final is slowly getting closer. Hence:
> >>
> >> AngeloGioacchino, should we ask the net maintainers to revert
> >> 868ff5f4944aa9 ("net: dsa: mt7530-mdio: read PHY address of switch from
> >> device tree") for now to resolve this regression? Reminder, there is
> >> nothing wrong with that commit per se afaik, it just exposes a problem
> >> that needs to be fixed first before it can be reapplied.
> > 
> > To be clear on this: I asked for the commit to be fixed such that it
> > guarantees
> > backwards compatibility with older device trees.
> > 
> > If no fix comes,
> 
> I haven't see any since that mail, did you? If not, I think...
> 
> > then I guess that we should ask them to revert this commit
> > until a fix is available.
> 
> ...it's time to ask them for the revert to resolve this for -rc7 (and
> avoid a last minute revert), or what do you think?
> 
> > I don't like this situation, either, btw.
> 
> I guess none of us does. :-/
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> #regzbot poke
>