[wireless-next,v2,2/3] wifi: mwifiex: debugfs: Drop unnecessary error check for debugfs_create_dir()

Kalle Valo kvalo at kernel.org
Thu Jan 18 05:06:51 PST 2024


Jinjie Ruan <ruanjinjie at huawei.com> wrote:

> debugfs_create_dir() returns ERR_PTR and never return NULL.
> 
> As Russell suggested, this patch removes the error checking for
> debugfs_create_dir(). This is because the DebugFS kernel API is developed
> in a way that the caller can safely ignore the errors that occur during
> the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in
> start_creating() which can handle it gracefully. So these checks are
> unnecessary.
> 
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie at huawei.com>
> Suggested-by: Russell King (Oracle) <linux at armlinux.org.uk>

Patch applied to wireless-next.git, thanks.

50180c7f8e3d wifi: mwifiex: debugfs: Drop unnecessary error check for debugfs_create_dir()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230903030216.1509013-3-ruanjinjie@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




More information about the Linux-mediatek mailing list