Aw: Re: [PATCH 2/2] arm64: dts: mediatek: Add initial MT7988A and BPI-R4

[Frank Wunderlich]

Hi

thanks Rafal for making the first loop of Dts-patches and splitting it and Angelo for first review.
Just my 2c on the thermal-part.

> Gesendet: Mittwoch, 03. Januar 2024 um 10:49 Uhr
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>
>
> Il 02/01/24 21:59, Rafał Miłecki ha scritto:
> > From: Rafał Miłecki <rafal at milecki.pl>
> > 
> > MT7988A (AKA MediaTek Filogic 880) is a quad-core ARM Cortex-A73
> > platform designed for Wi-Fi 7 devices (there is no wireless on SoC
> > though). The first public MT7988A device is Banana Pi BPI-R4.
> > 
> > Many SoC parts remain to be added (they need their own bindings or
> > depend on missing clocks). Those present block however are correct and
> > having base .dtsi will help testing & working on missing stuff.
> > 
> > +	thermal-zones {
> > +		cpu-thermal {
> > +			polling-delay-passive = <1000>;
> > +			polling-delay = <1000>;
> > +
> 
> Those thermal zones will not work, as they have no thermal-sensors - as this
> node is right now, it will produce a probe error and nothing else: please
> either drop it entirely or add support for the thermal sensors (lvts or auxadc?)
> and fix this node to use them.

it is LVTS and i upstreamed dt-binding and driverchange already, but it also needs a (infracfg-)reset which
i try to upstream soon after infracfg clock driver appear in next (imho daniels patch merged in subsystem tree today).

so also the infracfg-node will be needed in next round, if thermal part should be part of it (else not much is in the dtsi at this time).

> > +			trips {
> > +				crit {
> > +					temperature = <125000>;
> > +					hysteresis = <2000>;
> > +					type = "critical";
> > +				};
> > +
> > +				hot {
> > +					temperature = <120000>;
> > +					hysteresis = <2000>;
> > +					type = "hot";
> > +				};
> > +
> > +				active-high {
> > +					temperature = <115000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> 
> Active cooling is board specific. Keep only critical/hot trips in the SoC DT.
> 
> > +				};
> > +
> > +				active-med {
> > +					temperature = <85000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> > +				};
> > +
> > +				active-low {
> > +					temperature = <40000>;
> > +					hysteresis = <2000>;
> > +					type = "active";
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupt-parent = <&gic>;
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +};
> 
> Regards,
> Angelo

@rafal how do we sync our work? what is your codebase?
i currently work on daniels wip tree, but it does not contain your current splitting...
maybe daniel can include your splitted dts patches?

i already tried to fix some binding-issues in the full dts(i)....
waiting for vendor about clocks for mmc which are currently not matching actual binding (and using mt7986 compatible).

regards Frank