[PATCH net-next 0/9] net: dsa: cleanup EEE (part 1)
Vladimir Oltean
olteanv at gmail.com
Wed Dec 11 07:59:19 PST 2024
On Tue, Dec 10, 2024 at 02:17:52PM +0000, Russell King (Oracle) wrote:
> Hi,
>
> First part of DSA EEE cleanups.
>
> Patch 1 removes a useless test that is always false. dp->pl will always
> be set for user ports, so !dp->pl in the EEE methods will always be
> false.
>
> Patch 2 adds support for a new DSA support_eee() method, which tells
> DSA whether the DSA driver supports EEE, and thus whether the ethtool
> set_eee() and get_eee() methods should return -EOPNOTSUPP.
>
> Patch 3 adds a trivial implementation for this new method which
> indicates that EEE is supported.
>
> Patches 4..8 adds implementations for .supports_eee() to all drivers
> that support EEE in some form.
>
> Patch 9 switches the core DSA code to require a .supports_eee()
> implementation if DSA is supported. Any DSA driver that doesn't
> implement this method after this patch will not support the ethtool
> EEE methods.
>
> Part 2 will remove the (now) useless .get_mac_eee() DSA operation.
Reviewed-by: Vladimir Oltean <olteanv at gmail.com>
More information about the Linux-mediatek
mailing list