[PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages

Uwe Kleine-König ukleinek at kernel.org
Thu Dec 5 02:41:56 PST 2024


On Thu, Dec 05, 2024 at 08:10:13AM +0800, Zijun Hu wrote:
> diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
> index 07933d75ac815160a2580dce39fde7653a9502e1..1a1a9d6b8f2e8dfedefafde846315a06a167fbfb 100644
> --- a/arch/sparc/kernel/vio.c
> +++ b/arch/sparc/kernel/vio.c
> @@ -419,13 +419,13 @@ struct vio_remove_node_data {
>  	u64 node;
>  };
>  
> -static int vio_md_node_match(struct device *dev, void *arg)
> +static int vio_md_node_match(struct device *dev, const void *arg)
>  {
>  	struct vio_dev *vdev = to_vio_dev(dev);
> -	struct vio_remove_node_data *node_data;
> +	const struct vio_remove_node_data *node_data;
>  	u64 node;
>  
> -	node_data = (struct vio_remove_node_data *)arg;
> +	node_data = (const struct vio_remove_node_data *)arg;

You can just drop the cast here. But maybe that is better be done i a
separate change.

>  	node = vio_vdev_node(node_data->hp, vdev);
>  

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20241205/1878644d/attachment.sig>


More information about the Linux-mediatek mailing list