Aw: Re: [PATCH v2 11/18] arm64: dts: mediatek: mt7988: add chosen node on bpi-r4

[Frank Wunderlich]

regards Frank


> Gesendet: Montag, 2. Dezember 2024 um 16:58
> Von: "Krzysztof Kozlowski" <krzk at kernel.org>
> An: "Frank Wunderlich" <linux at fw-web.de>, "Rob Herring" <robh at kernel.org>, "Krzysztof Kozlowski" <krzk+dt at kernel.org>, "Conor Dooley" <conor+dt at kernel.org>, "Matthias Brugger" <matthias.bgg at gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>
> CC: "Frank Wunderlich" <frank-w at public-files.de>, devicetree at vger.kernel.org, linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-mediatek at lists.infradead.org
> Betreff: Re: [PATCH v2 11/18] arm64: dts: mediatek: mt7988: add chosen node on bpi-r4
>
> On 02/12/2024 15:29, Frank Wunderlich wrote:
> > Am 2. Dezember 2024 14:46:24 MEZ schrieb Krzysztof Kozlowski <krzk at kernel.org>:
> >> On 02/12/2024 13:25, Frank Wunderlich wrote:
> >>> From: Frank Wunderlich <frank-w at public-files.de>
> >>>
> >>> Add chosen node on Bananapi R4 board with stdout and default bootargs.
> >>>
> >>> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> >>> ---
> >>>  arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts | 5 +++++
> >>>  1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> index 9037f35857a9..1c2a806f6f6c 100644
> >>> --- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts
> >>> @@ -9,6 +9,11 @@ / {
> >>>  	model = "Banana Pi BPI-R4";
> >>>  	chassis-type = "embedded";
> >>>
> >>> +	chosen {
> >>> +		stdout-path = &serial0;
> >>> +		bootargs = "console=ttyS0,115200n1";
> >>
> >> Drop or merge into stdout path.
> >
> > Have you an example to pass speed setting to stdout-path? As it is only a phandle it is not clear to me how to merge these 2...
> It is really trivial to find, considering that 66% of files have it.
>
> git grep stdout

thanks, wasn't aware that string is here also accepted...found it ("git grep stdout-path" is much better here :) )

will change both lines to this single one:

stdout-path = "serial0:115200n8";

> Best regards,
> Krzysztof
> </frank-w at public-files.de></frank-w at public-files.de></krzk at kernel.org></frank-w at public-files.de></angelogioacchino.delregno at collabora.com></matthias.bgg at gmail.com></conor+dt at kernel.org></krzk+dt at kernel.org></robh at kernel.org></linux at fw-web.de></krzk at kernel.org>