[PATCH v2 2/2] ufs: core: force reset after mcq abort all
Bart Van Assche
bvanassche at acm.org
Tue Aug 27 08:55:14 PDT 2024
On 8/25/24 8:45 PM, peter.wang at mediatek.com wrote:
> From: Peter Wang <peter.wang at mediatek.com>
>
> In mcq mode gerneal case, cq (head/tail) pointer is same as
Please capitalize "MCQ" and please fix the spelling of "general".
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 4bcd4e5b62bd..d9ef8f0279da 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6519,6 +6519,8 @@ static bool ufshcd_abort_all(struct ufs_hba *hba)
> /* Complete the requests that are cleared by s/w */
> ufshcd_complete_requests(hba, false);
>
> + if (is_mcq_enabled(hba))
> + return true;
> return ret != 0;
> }
Please add a comment above the new if-test that explains why that code
is present otherwise it will be hard to understand why that statement
has been introduced.
Thanks,
Bart.
More information about the Linux-mediatek
mailing list