[PATCH] memory: mtk-smi: Simplify using devm_clk_get_enabled()

Krzysztof Kozlowski krzk at kernel.org
Tue Aug 20 05:40:21 PDT 2024


On 20/08/2024 14:34, Rong Qianfeng wrote:
> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
> and the clock will automatically be disabled, unprepared and freed when
> the device is unbound from the bus. 

That's obvious, drop. You do not have to explain basic APIs. Instead say
what is being simplified here.

> So simplify mtk_smi_common_probe()
> accordingly.

Also explain that you fix bug of missing unprepare in unbind and add
Fixes+CC stable tags.

Best regards,
Krzysztof




More information about the Linux-mediatek mailing list