[PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy

Ido Schimmel idosch at idosch.org
Wed Apr 10 08:05:47 PDT 2024


On Wed, Apr 10, 2024 at 06:13:43AM -0700, Breno Leitao wrote:
> For dummy devices, exit earlier at free_netdev() instead of executing
> the whole function. This is necessary, because dummy devices are
> special, and shouldn't have the second part of the function executed.
> 
> Otherwise reg_state, which is NETREG_DUMMY, will be overwritten and
> there will be no way to identify that this is a dummy device. Also, this
> device do not need the final put_device(), since dummy devices are not
> registered (through register_netdevice()), where the device reference is
> increased (at netdev_register_kobject()/device_add()).
> 
> Suggested-by: Jakub Kicinski <kuba at kernel.org>
> Signed-off-by: Breno Leitao <leitao at debian.org>

Reviewed-by: Ido Schimmel <idosch at nvidia.com>



More information about the Linux-mediatek mailing list