[PATCH v5] ufs: core: wlun send SSU timeout recovery

Bart Van Assche bvanassche at acm.org
Wed Sep 27 11:31:57 PDT 2023


On 9/26/23 20:35, peter.wang at mediatek.com wrote:
> +	if (hba->pm_op_in_progress) {
> +		if (ufshcd_link_recovery(hba))
> +			err = FAILED;
> +
> +		return err;
> +	}

This patch looks good to me but I wish the above code would have been
written using the style that is preferred in the Linux kernel:

	if (hba->pm_op_in_progress && ufshcd_link_recovery(hba) < 0)
		return FAILED;

Thanks,

Bart.




More information about the Linux-mediatek mailing list