[PATCH v7 39/49] media: usb: hackrf: Stop direct calls to queue num_buffers field
Hans Verkuil
hverkuil-cisco at xs4all.nl
Tue Sep 19 07:20:10 PDT 2023
On 14/09/2023 15:33, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard at collabora.com>
> ---
> drivers/media/usb/hackrf/hackrf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
> index 3e535be2c520..9c0ecd5f056c 100644
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -753,12 +753,13 @@ static int hackrf_queue_setup(struct vb2_queue *vq,
> unsigned int *nplanes, unsigned int sizes[], struct device *alloc_devs[])
> {
> struct hackrf_dev *dev = vb2_get_drv_priv(vq);
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
>
> dev_dbg(dev->dev, "nbuffers=%d\n", *nbuffers);
>
> /* Need at least 8 buffers */
> - if (vq->num_buffers + *nbuffers < 8)
> - *nbuffers = 8 - vq->num_buffers;
> + if (q_num_bufs + *nbuffers < 8)
> + *nbuffers = 8 - q_num_bufs;
Drop check, set min_buffers_needed to 8.
Regards,
Hans
> *nplanes = 1;
> sizes[0] = PAGE_ALIGN(dev->buffersize);
>
More information about the Linux-mediatek
mailing list