[PATCH net-next 5/9] net: dsa: mt7530: Convert to platform remove callback returning void

Florian Fainelli f.fainelli at gmail.com
Mon Sep 18 13:52:08 PDT 2023


On 9/18/23 12:19, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
-- 
Florian




More information about the Linux-mediatek mailing list