[PATCH v2 04/11] drm/mediatek: Add OVL compatible name for MT8195

AngeloGioacchino Del Regno angelogioacchino.delregno at collabora.com
Mon Sep 18 02:21:44 PDT 2023


Il 18/09/23 11:09, CK Hu (胡俊光) ha scritto:
> On Mon, 2023-09-18 at 16:42 +0800, Hsiao Chien Sung wrote:
>> Add OVL compatible name for MT8195.
> 
> Reviewed-by: CK Hu <ck.hu at mediatek.com>
> 
> but it's weird to put this patch into IGT series. Without this patch,
> mt8195 drm driver does not work not only IGT.
> 

The driver does work because the devicetree node declares two compatibles,
"mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl" where the second
compatible is matched in mtk_drm_drv, and the first is matched in mtk_disp_ovl
as both are platform_driver.

This commit is not necessary, even... :-)

Regards,
Angelo

> Regards,
> CK
> 
>>
>> Signed-off-by: Hsiao Chien Sung <shawn.sung at mediatek.com>
>> ---
>>   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> index 93552d76b6e7..7759a06e5c0e 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> @@ -715,6 +715,8 @@ static const struct of_device_id
>> mtk_ddp_comp_dt_ids[] = {
>>   	  .data = (void *)MTK_DISP_OVL },
>>   	{ .compatible = "mediatek,mt8192-disp-ovl",
>>   	  .data = (void *)MTK_DISP_OVL },
>> +	{ .compatible = "mediatek,mt8195-disp-ovl",
>> +	  .data = (void *)MTK_DISP_OVL },
>>   	{ .compatible = "mediatek,mt8183-disp-ovl-2l",
>>   	  .data = (void *)MTK_DISP_OVL_2L },
>>   	{ .compatible = "mediatek,mt8192-disp-ovl-2l",





More information about the Linux-mediatek mailing list