[PATCH v5 2/3] dt-binding: mediatek: integrate MDP RDMA to one binding
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Tue Sep 12 01:16:14 PDT 2023
On 12/09/2023 09:56, Moudy Ho wrote:
> Due to the same hardware design, MDP RDMA needs to
> be integrated into the same binding.
>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
This applies to entire patchset. It is not dt-binding, but dt-bindings.
> Signed-off-by: Moudy Ho <moudy.ho at mediatek.com>
> ---
> .../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------------
> .../bindings/media/mediatek,mdp3-rdma.yaml | 5 +-
> 2 files changed, 3 insertions(+), 90 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> deleted file mode 100644
> index dd12e2ff685c..000000000000
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rdma.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: MediaTek MDP RDMA
> -
> -maintainers:
> - - Chun-Kuang Hu <chunkuang.hu at kernel.org>
> - - Philipp Zabel <p.zabel at pengutronix.de>
> -
> -description:
> - The MediaTek MDP RDMA stands for Read Direct Memory Access.
> - It provides real time data to the back-end panel driver, such as DSI,
> - DPI and DP_INTF.
> - It contains one line buffer to store the sufficient pixel data.
> - RDMA device node must be siblings to the central MMSYS_CONFIG node.
> - For a description of the MMSYS_CONFIG binding, see
> - Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details.
> -
> -properties:
> - compatible:
> - const: mediatek,mt8195-vdo1-rdma
> -
> - reg:
> - maxItems: 1
> -
> - interrupts:
> - maxItems: 1
> -
> - power-domains:
> - maxItems: 1
> -
> - clocks:
> - items:
> - - description: RDMA Clock
This is different and you did not explain it in commit msg.
Another difference - mboxes. Looks like you did not test your DTS...
Best regards,
Krzysztof
More information about the Linux-mediatek
mailing list