[PATCH v4 1/3] dt-bindings: media: Add bindings for THine THP7312 ISP
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Fri Oct 27 05:46:34 PDT 2023
Hi Sakari,
On Fri, Oct 27, 2023 at 12:35:05PM +0000, Sakari Ailus wrote:
> On Fri, Oct 27, 2023 at 03:19:29PM +0300, Laurent Pinchart wrote:
> > On Fri, Oct 27, 2023 at 11:55:52AM +0000, Sakari Ailus wrote:
> > > Hi Laurent,
> > >
> > > Thank you for the patchset any my apologies for not reviewing it earlier.
> >
> > No worries. Thank you for reviewing it now :-)
> >
> > > On Tue, Oct 17, 2023 at 04:21:01PM +0300, Laurent Pinchart wrote:
> > > > From: Paul Elder <paul.elder at ideasonboard.com>
> > > >
> > > > The THP7312 is an external ISP from THine. Add DT bindings for it.
> > > >
> > > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > > > Co-developed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > > ---
> > > > Changes since v2:
> > > >
> > > > - Drop description of reg property
> > > > - Improve thine,boot-mode property documentation
> > > > - Making thine,boot-mode property optional
> > > > - Don't use underscores in supplies names
> > > > ---
> > > > .../bindings/media/i2c/thine,thp7312.yaml | 226 ++++++++++++++++++
> > > > MAINTAINERS | 7 +
> > > > 2 files changed, 233 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > > > new file mode 100644
> > > > index 000000000000..0758d8d44826
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > > > @@ -0,0 +1,226 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +# Copyright (c) 2023 Ideas on Board
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/media/i2c/thine,thp7312.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: THine THP7312
> > > > +
> > > > +maintainers:
> > > > + - Paul Elder <paul.elder@@ideasonboard.com>
> > > > +
> > > > +description:
> > > > + The THP7312 is a standalone ISP controlled over i2c, and is capable of
> > > > + various image processing and correction functions, including 3A control. It
> > > > + can be connected to CMOS image sensors from various vendors, supporting both
> > > > + MIPI CSI-2 and parallel interfaces. It can also output on either MIPI CSI-2
> > > > + or parallel. The hardware is capable of transmitting and receiving MIPI
> > > > + interlaved data strams with data types or multiple virtual channel
> > > > + identifiers.
> > > > +
> > > > +allOf:
> > > > + - $ref: ../video-interface-devices.yaml#
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + const: thine,thp7312
> > > > +
> > > > + reg:
> > > > + maxItems: 1
> > > > +
> > > > + clocks:
> > > > + maxItems: 1
> > > > + description: CLKI clock input
> > > > +
> > > > + thine,boot-mode:
> > > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > > + minimum: 0
> > > > + maximum: 1
> > > > + default: 1
> > > > + description:
> > > > + Boot mode of the THP7312, reflecting the value of the BOOT[0] pin strap.
> > > > + 0 is for the SPI/2-wire slave boot, 1 is for the SPI master boot (from
> > > > + external flash ROM).
> > > > +
> > > > + reset-gpios:
> > > > + maxItems: 1
> > > > + description:
> > > > + Reference to the GPIO connected to the RESET_N pin, if any.
> > > > + Must be released (set high) after all supplies are applied.
> > > > +
> > > > + vddcore-supply:
> > > > + description:
> > > > + 1.2V supply for core, PLL, MIPI rx and MIPI tx.
> > > > +
> > > > + vhtermrx-supply:
> > > > + description:
> > > > + Supply for input (RX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
> > > > +
> > > > + vddtx-supply:
> > > > + description:
> > > > + Supply for output (TX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
> > > > +
> > > > + vddhost-supply:
> > > > + description:
> > > > + Supply for host interface. 1.8V, 2.8V, or 3.3V.
> > > > +
> > > > + vddcmos-supply:
> > > > + description:
> > > > + Supply for sensor interface. 1.8V, 2.8V, or 3.3V.
> > > > +
> > > > + vddgpio-0-supply:
> > > > + description:
> > > > + Supply for GPIO_0. 1.8V, 2.8V, or 3.3V.
> > > > +
> > > > + vddgpio-1-supply:
> > > > + description:
> > > > + Supply for GPIO_1. 1.8V, 2.8V, or 3.3V.
> > > > +
> > > > + orientation: true
> > > > + rotation: true
> > > > +
> > > > + port:
> > > > + $ref: /schemas/graph.yaml#/$defs/port-base
> > > > + additionalProperties: false
> > > > +
> > > > + properties:
> > > > + endpoint:
> > > > + $ref: /schemas/media/video-interfaces.yaml#
> > > > + unevaluatedProperties: false
> > > > +
> > > > + properties:
> > > > + data-lanes:
> > > > + description:
> > > > + This property is for lane reordering between the THP7312 and the
> > > > + SoC. The sensor supports either two-lane, or four-lane operation.
> > > > + If this property is omitted four-lane operation is assumed. For
> > > > + two-lane operation the property must be set to <1 2>.
> > >
> > > How are link frequencies determined by the device?
> >
> > The link frequency is not under direct control of the host. There are
> > registers to select between mode presets, each of them producing a
> > particular link frequency.
>
> If they are known, one could only allow setting the modes with known-good
> link requencies. This could be added later on, too, affecting systems with
> link-frequencies set. I guess you could also add it now, as optional.
I vote for later :-)
> Where's the link frequency information available? In documentation or in
> on the firmware API?
In the documentation (which is not public I'm afraid).
> > > The description above also says the parallel interface is supported. The
> > > bindings do not reflect that however.
> > >
> > > Same for the sensor node below.
> > >
> > > Is the intention to add support for these later on? In that case you'll
> > > need bus-type and default that to CSI-2 for DTs conforming to these
> > > bindings.
> >
> > While documentation claims that parallel interfaces are supported, we
> > haven't been able to test this at all, due to lack of a suitable
> > hardware test platform. The intention is indeed to add support for them
> > later. I will add the bus-type property here.
>
> Using a CSI-2 D-PHY default later on would be workable, too, IMO. Up to
> you.
Being explicit is nice.
> > > > + minItems: 2
> > > > + maxItems: 4
> > > > + items:
> > > > + maximum: 4
> > > > +
> > > > + sensors:
> > > > + type: object
> > > > + description: List of connected sensors
> > > > +
> > > > + properties:
> > > > + "#address-cells":
> > > > + const: 1
> > > > +
> > > > + "#size-cells":
> > > > + const: 0
> > > > +
> > > > + patternProperties:
> > > > + "^sensor@[01]":
> > > > + type: object
> > > > + description:
> > > > + Sensors connected to the first and second input, with one node per
> > > > + sensor.
> > > > +
> > > > + properties:
> > > > + thine,model:
> > > > + $ref: /schemas/types.yaml#/definitions/string
> > > > + description:
> > > > + Model of the connected sensors. Must be a valid compatible string.
> > > > +
> > > > + reg:
> > > > + maxItems: 1
> > > > + description: THP7312 input port number
> > > > +
> > > > + data-lanes:
> > > > + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes
> > > > + items:
> > > > + maxItems: 4
> > > > + description:
> > > > + This property is for lane reordering between the THP7312 and the imaging
> > > > + sensor that it is connected to.
> > > > +
> > > > + patternProperties:
> > > > + ".*-supply":
> > > > + description: Power supplies for the sensor
> > > > +
> > > > + required:
> > > > + - reg
> > > > + - data-lanes
> > > > +
> > > > + additionalProperties: false
> > > > +
> > > > + required:
> > > > + - "#address-cells"
> > > > + - "#size-cells"
> > > > +
> > > > + additionalProperties: false
> > > > +
> > > > +required:
> > > > + - compatible
> > > > + - reg
> > > > + - reset-gpios
> > > > + - clocks
> > > > + - vddcore-supply
> > > > + - vhtermrx-supply
> > > > + - vddtx-supply
> > > > + - vddhost-supply
> > > > + - vddcmos-supply
> > > > + - vddgpio-0-supply
> > > > + - vddgpio-1-supply
> > > > + - sensors
> > > > + - port
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/gpio/gpio.h>
> > > > +
> > > > + i2c {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + camera at 61 {
> > > > + compatible = "thine,thp7312";
> > > > + reg = <0x61>;
> > > > +
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&cam1_pins_default>;
> > > > +
> > > > + reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>;
> > > > + clocks = <&camera61_clk>;
> > > > +
> > > > + vddcore-supply = <&vsys_v4p2>;
> > > > + vhtermrx-supply = <&vsys_v4p2>;
> > > > + vddtx-supply = <&vsys_v4p2>;
> > > > + vddhost-supply = <&vsys_v4p2>;
> > > > + vddcmos-supply = <&vsys_v4p2>;
> > > > + vddgpio-0-supply = <&vsys_v4p2>;
> > > > + vddgpio-1-supply = <&vsys_v4p2>;
> > > > +
> > > > + orientation = <0>;
> > > > + rotation = <0>;
> > > > +
> > > > + sensors {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + sensor at 0 {
> > > > + thine,model = "sony,imx258";
> > > > + reg = <0>;
> > > > +
> > > > + data-lanes = <4 1 3 2>;
> > >
> > > Does the device support lane mapping?
> >
> > Yes it does, both on the input and output.
>
> Nice to know there are more devices supporting it. It's not very common.
>
> > > > +
> > > > + dovdd-supply = <&vsys_v4p2>;
> > > > + avdd-supply = <&vsys_v4p2>;
> > > > + dvdd-supply = <&vsys_v4p2>;
> > > > + };
> > > > + };
> > > > +
> > > > + port {
> > > > + thp7312_2_endpoint: endpoint {
> > > > + remote-endpoint = <&mipi_thp7312_2>;
> > > > + data-lanes = <4 2 1 3>;
> > > > + };
> > > > + };
> > > > + };
> > > > + };
> > > > +...
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 3b47e0b56859..7451367e6780 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -21448,6 +21448,13 @@ S: Maintained
> > > > F: Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > > F: drivers/platform/x86/think-lmi.?
> > > >
> > > > +THP7312 ISP DRIVER
> > > > +M: Paul Elder <paul.elder at ideasonboard.com>
> > > > +L: linux-media at vger.kernel.org
> > > > +S: Maintained
> > > > +T: git git://linuxtv.org/media_tree.git
> > > > +F: Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > > > +
> > > > THUNDERBOLT DMA TRAFFIC TEST DRIVER
> > > > M: Isaac Hazan <isaac.hazan at intel.com>
> > > > L: linux-usb at vger.kernel.org
--
Regards,
Laurent Pinchart
More information about the Linux-mediatek
mailing list