[PATCH net-next] net: dsa: mt753x: remove mt753x_phylink_pcs_link_up()

Florian Fainelli f.fainelli at gmail.com
Mon Oct 2 16:24:48 PDT 2023


On 9/27/23 05:13, Russell King (Oracle) wrote:
> Remove the mt753x_phylink_pcs_link_up() function for two reasons:
> 
> 1) priv->pcs[i].pcs.neg_mode is set true, meaning it doesn't take a
>     MLO_AN_FIXED anymore, but one of PHYLINK_PCS_NEG_*. However, this
>     is inconsequential due to...
> 2) priv->pcs[port].pcs.ops is always initialised to point at
>     mt7530_pcs_ops, which does not have a pcs_link_up() member.
> 
> So, let's remove mt753x_phylink_pcs_link_up() entirely.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>

Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
-- 
Florian




More information about the Linux-mediatek mailing list