[net-next PATCH RFC v3 6/8] dt-bindings: net: Document Qcom QCA807x PHY package
Andrew Lunn
andrew at lunn.ch
Mon Nov 27 16:30:08 PST 2023
> +$ref: ethernet-phy-package.yaml#
> +
> +properties:
> + qcom,package-mode:
> + enum:
> + - qsgmii
> + - psgmii
> +
> + qcom,tx-driver-strength:
> + description: set the TX Amplifier value in mv.
> + If not defined, 600mw is set by default.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [140, 160, 180, 200, 220,
> + 240, 260, 280, 300, 320,
> + 400, 500, 600]
This is O.K, you are describing package properties, even if i don't
agree about qcom,package-mode.
> +patternProperties:
> + ^ethernet-phy(@[a-f0-9]+)?$:
> + $ref: ethernet-phy.yaml#
> +
> + properties:
> + gpio-controller:
> + description: set the output lines as GPIO instead of LEDs
> + type: boolean
> +
> + '#gpio-cells':
> + description: number of GPIO cells for the PHY
> + const: 2
But now you are describing PHY properties. These belong on a .yaml of
its own, just like qca,ar803x.yaml defines properties for the AR803x
PHY.
Andrew
More information about the Linux-mediatek
mailing list