[PATCH 00/14] power: reset: Drop platform_driver_probe() and convert to platform remove callback returning void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sat Nov 4 14:15:02 PDT 2023


Hello,

there are two different types of patches here that would justify to
different series. But as the patches are not independant I chose to put
them in a single series.

The first three patches drop usage of platform_driver_probe(). This is a
concept that isn't so relevant any more today. I didn't check, but it
saves typically only a few 100k and there are thoughts to deprecate it
to simplify the core. Getting the usage right is not trivial though the
at91 drivers got it nearly right. The alternative to these patches is to
add __ref to the driver struct ideally with a comment describing the
need like is e.g. done in commit 5b44abbc39ca ("platform/x86: hp-wmi::
Mark driver struct with __refdata to prevent section mismatch warning").

The remaining patches convert the platform drivers to .remove_new(), see
commit 5c5a7680e67b ("platform: Provide a remove callback that returns
no value") for an extended explanation and the eventual goal. All
conversions but one are trivial as the remove functions return zero
unconditionally. The only exception is the tps65086-restart driver.

Best regards
Uwe

Uwe Kleine-König (14):
  power: reset: at91-poweroff: Stop using module_platform_driver_probe()
  power: reset: at91-reset:: Stop using module_platform_driver_probe()
  power: reset: at91-sama5d2_shdwc: Stop using
    module_platform_driver_probe()
  power: reset: as3722-poweroff: Convert to platform remove callback
    returning void
  power: reset: at91-poweroff: Convert to platform remove callback
    returning void
  power: reset: atc260x-poweroff: Convert to platform remove callback
    returning void
  power: reset: ltc2952-poweroff: Convert to platform remove callback
    returning void
  power: reset: mt6323-poweroff: Convert to platform remove callback
    returning void
  power: reset: qnap-poweroff: Convert to platform remove callback
    returning void
  power: reset: regulator-poweroff: Convert to platform remove callback
    returning void
  power: reset: restart-poweroff: Convert to platform remove callback
    returning void
  power: reset: rmobile-reset: Convert to platform remove callback
    returning void
  power: reset: syscon-poweroff: Convert to platform remove callback
    returning void
  power: reset: tps65086-restart: Convert to platform remove callback
    returning void

 drivers/power/reset/as3722-poweroff.c    |  6 ++----
 drivers/power/reset/at91-poweroff.c      | 11 +++++------
 drivers/power/reset/at91-reset.c         |  9 +++++----
 drivers/power/reset/at91-sama5d2_shdwc.c |  9 +++++----
 drivers/power/reset/atc260x-poweroff.c   |  6 ++----
 drivers/power/reset/ltc2952-poweroff.c   |  5 ++---
 drivers/power/reset/mt6323-poweroff.c    |  6 ++----
 drivers/power/reset/qnap-poweroff.c      |  5 ++---
 drivers/power/reset/regulator-poweroff.c |  6 ++----
 drivers/power/reset/restart-poweroff.c   |  6 ++----
 drivers/power/reset/rmobile-reset.c      |  5 ++---
 drivers/power/reset/syscon-poweroff.c    |  6 ++----
 drivers/power/reset/tps65086-restart.c   | 12 +++++++-----
 13 files changed, 40 insertions(+), 52 deletions(-)


base-commit: e27090b1413ff236ca1aec26d6b022149115de2c
-- 
2.42.0




More information about the Linux-mediatek mailing list