[PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems
Icenowy Zheng
uwu at icenowy.me
Mon May 29 09:20:54 PDT 2023
In the commit I reverted as the first commit of this patchset, the
of_iomap function call, which allows multiple mapping of the same
physical memory space, is replaced to calling devm_of_iomap, which
registers exclusivity, and on my system (mt8173-elm), preventing display
from working.
So I reverted it, and to really solve the problem that the original
commit wants to solve, I read the source of auxadc-thermal and realized
that the address of these two memory blocks are not saved after probe,
and they're only used when initializing the thermal sensors. This leads
to my final fix, which is the second commit here, that adds of_iounmap
just to the probe function.
Icenowy Zheng (2):
Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource
leak in mtk_thermal_probe"
thermal/drivers/mediatek: unmap foreign MMIO after probing
drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++-----------
1 file changed, 24 insertions(+), 22 deletions(-)
--
2.39.1
More information about the Linux-mediatek
mailing list