[PATCH v7 06/19] clk: mediatek: Add MT8188 camsys clock support

[Garmin Chang (張家銘)]

On Fri, 2023-03-31 at 11:53 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 31/03/23 10:21, Garmin.Chang ha scritto:
> > Add MT8188 camsys clock controllers which provide clock gate
> > control for camera IP blocks.
> > 
> > Signed-off-by: Garmin.Chang <Garmin.Chang at mediatek.com>
> > Reviewed-by: Chen-Yu Tsai <wenst at chromium.org>
> > ---
> >   drivers/clk/mediatek/Kconfig          |   7 ++
> >   drivers/clk/mediatek/Makefile         |   1 +
> >   drivers/clk/mediatek/clk-mt8188-cam.c | 120
> > ++++++++++++++++++++++++++
> >   3 files changed, 128 insertions(+)
> >   create mode 100644 drivers/clk/mediatek/clk-mt8188-cam.c
> > 
> > diff --git a/drivers/clk/mediatek/Kconfig
> > b/drivers/clk/mediatek/Kconfig
> > index 681d392620c5..9170f76a8ee7 100644
> > --- a/drivers/clk/mediatek/Kconfig
> > +++ b/drivers/clk/mediatek/Kconfig
> > @@ -692,6 +692,13 @@ config COMMON_CLK_MT8188
> >       help
> >             This driver supports MediaTek MT8188 clocks.
> > 
> > +config COMMON_CLK_MT8188_CAMSYS
> > +     tristate "Clock driver for MediaTek MT8188 camsys"
> > +     depends on COMMON_CLK_MT8188_VPPSYS
> > +     default COMMON_CLK_MT8188_VPPSYS
> > +     help
> > +       This driver supports MediaTek MT8188 camsys and camsys_raw
> > clocks.
> > +
> >   config COMMON_CLK_MT8192
> >       tristate "Clock driver for MediaTek MT8192"
> >       depends on ARM64 || COMPILE_TEST
> > diff --git a/drivers/clk/mediatek/Makefile
> > b/drivers/clk/mediatek/Makefile
> > index 1a642510ce38..c235e9a0d305 100644
> > --- a/drivers/clk/mediatek/Makefile
> > +++ b/drivers/clk/mediatek/Makefile
> > @@ -102,6 +102,7 @@ obj-$(CONFIG_COMMON_CLK_MT8186_VENCSYS) += clk-
> > mt8186-venc.o
> >   obj-$(CONFIG_COMMON_CLK_MT8186_WPESYS) += clk-mt8186-wpe.o
> >   obj-$(CONFIG_COMMON_CLK_MT8188) += clk-mt8188-apmixedsys.o clk-
> > mt8188-topckgen.o \
> >                                  clk-mt8188-peri_ao.o clk-mt8188-
> > infra_ao.o
> > +j-$(CONFIG_COMMON_CLK_MT8188_CAMSYS) += clk-mt8188-cam.o
> 
> Please fix that typo here.
> 
> After which,
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno at collabora.com>
> 
Thank you for taking the time to help review.

Ok, I will fix it in v8.

Thanks,
Best regards,
Garmin


>