soc: mediatek: mtk-svs: fix passing zero to 'PTR_ERR'

Matthias Brugger matthias.bgg at gmail.com
Thu Mar 30 02:30:14 PDT 2023



On 16/02/2023 14:25, Roger Lu wrote:
> nvmem_cell_get() cannot return NULL so checking for NULL is wrong here.
> 
> Signed-off-by: Roger Lu <roger.lu at mediatek.com>
> Fixes: 6c7174fd90a4690 ("soc: mediatek: mtk-svs: use svs get efuse common function")
> Reported-by: kernel test robot <lkp at intel.com>
> Reported-by: Dan Carpenter <error27 at gmail.com>
> Link: https://lore.kernel.org/r/202302160720.N64SWT4l-lkp@intel.com/

Applied, thanks.

> ---
>   drivers/soc/mediatek/mtk-svs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index a7eb019b5157..8127fb6d587b 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1726,7 +1726,7 @@ static int svs_get_efuse_data(struct svs_platform *svsp,
>   	struct nvmem_cell *cell;
>   
>   	cell = nvmem_cell_get(svsp->dev, nvmem_cell_name);
> -	if (IS_ERR_OR_NULL(cell)) {
> +	if (IS_ERR(cell)) {
>   		dev_err(svsp->dev, "no \"%s\"? %ld\n",
>   			nvmem_cell_name, PTR_ERR(cell));
>   		return PTR_ERR(cell);



More information about the Linux-mediatek mailing list