[PATCH v5 02/18] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers

Kunihiko Hayashi hayashi.kunihiko at socionext.com
Fri Mar 3 08:21:43 PST 2023


On 2023/03/02 5:14, Daniel Lezcano wrote:
> The thermal zone device structure is exposed to the different drivers
> and obviously they access the internals while that should be
> restricted to the core thermal code.
> 
> In order to self-encapsulate the thermal core code, we need to prevent
> the drivers accessing directly the thermal zone structure and provide
> accessor functions to deal with.
> 
> Use the devdata accessor introduced in the previous patch.
> 
> No functional changes intended.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas at ragnatech.se> #R-Car
> Acked-by: Mark Brown <broonie at kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno at collabora.com> #MediaTek auxadc and lvts
> Reviewed-by: Balsam CHIHI <bchihi at baylibre.com> #Mediatek lvts
> Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource at dm.renesas.com> #da9062
> Reviewed-by: Baolin Wang <baolin.wang at linux.alibaba.com>  #spread
> Acked-by: Jernej Skrabec <jernej.skrabec at gmail.com> #sun8i_thermal
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> Acked-by: Florian Fainelli <f.fainelli at gmail.com> #Broadcom
> Reviewed-by: Dhruva Gole <d-gole at ti.com> # K3 bandgap

(snip)

> diff --git a/drivers/thermal/uniphier_thermal.c
> b/drivers/thermal/uniphier_thermal.c
> index 47801841b3f5..aef6119cc004 100644
> --- a/drivers/thermal/uniphier_thermal.c
> +++ b/drivers/thermal/uniphier_thermal.c
> @@ -187,7 +187,7 @@ static void uniphier_tm_disable_sensor(struct
> uniphier_tm_dev *tdev)
> 
>   static int uniphier_tm_get_temp(struct thermal_zone_device *tz, int
> *out_temp)
>   {
> -	struct uniphier_tm_dev *tdev = tz->devdata;
> +	struct uniphier_tm_dev *tdev = thermal_zone_device_priv(tz);

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com> #uniphier

Thank you,

---
Best Regards
Kunihiko Hayashi



More information about the Linux-mediatek mailing list