[PATCH v7 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support

kernel test robot lkp at intel.com
Sat Jun 24 01:35:12 PDT 2023


Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20230623]
[cannot apply to bluetooth/master wireless/main wireless-next/main linus/master v6.4-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btmtk-introduce-btmtk-reset-work/20230624-100756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link:    https://lore.kernel.org/r/ed1d0e9fe7758dac8a05dcff97c7dcb8e9b0be39.1687565769.git.objelf%40gmail.com
patch subject: [PATCH v7 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
config: x86_64-randconfig-a002-20230621 (https://download.01.org/0day-ci/archive/20230624/202306241617.Dw81i6id-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230624/202306241617.Dw81i6id-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306241617.Dw81i6id-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump':
>> drivers/bluetooth/btmtk.c:381:44: error: 'struct hci_dev' has no member named 'dump'
     381 |                 schedule_delayed_work(&hdev->dump.dump_timeout,
         |                                            ^~


vim +381 drivers/bluetooth/btmtk.c

   364	
   365	int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb)
   366	{
   367		struct btmediatek_data *data = hci_get_priv(hdev);
   368		int err;
   369	
   370		if (!IS_ENABLED(CONFIG_DEV_COREDUMP))
   371			return 0;
   372	
   373		switch (data->cd_info.state) {
   374		case HCI_DEVCOREDUMP_IDLE:
   375			err = hci_devcd_init(hdev, MTK_COREDUMP_SIZE);
   376			if (err < 0)
   377				break;
   378			data->cd_info.cnt = 0;
   379	
   380			/* It is supposed coredump can be done within 5 seconds */
 > 381			schedule_delayed_work(&hdev->dump.dump_timeout,
   382					      msecs_to_jiffies(5000));
   383			fallthrough;
   384		case HCI_DEVCOREDUMP_ACTIVE:
   385		default:
   386			err = hci_devcd_append(hdev, skb);
   387			if (err < 0)
   388				break;
   389			data->cd_info.cnt++;
   390	
   391			/* Mediatek coredump data would be more than MTK_COREDUMP_NUM */
   392			if (data->cd_info.cnt > MTK_COREDUMP_NUM &&
   393			    skb->len > sizeof(MTK_COREDUMP_END) &&
   394			    !memcmp((char *)&skb->data[skb->len - sizeof(MTK_COREDUMP_END)],
   395				    MTK_COREDUMP_END, sizeof(MTK_COREDUMP_END) - 1)) {
   396				bt_dev_info(hdev, "Mediatek coredump end");
   397				hci_devcd_complete(hdev);
   398			}
   399	
   400			break;
   401		}
   402	
   403		if (err < 0)
   404			kfree_skb(skb);
   405	
   406		return err;
   407	}
   408	EXPORT_SYMBOL_GPL(btmtk_process_coredump);
   409	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



More information about the Linux-mediatek mailing list