wifi: mt7601u: replace strlcpy() with strscpy()
Kalle Valo
kvalo at kernel.org
Thu Jun 15 00:46:49 PDT 2023
Azeem Shaikh <azeemshaikh38 at gmail.com> wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since DEV_ASSIGN is only used by
> TRACE macros and the return values are ignored.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38 at gmail.com>
> Reviewed-by: Kees Cook <keescook at chromium.org>
Patch applied to wireless-next.git, thanks.
7edbd53a58a8 wifi: mt7601u: replace strlcpy() with strscpy()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
More information about the Linux-mediatek
mailing list