Aw: Re: Re: Re: Re: Re: [PATCH v3 0/5] arm: dts: mt7623: relocate gmacs, mt7530 switch, and add port at 5

[Matthias Brugger]

On 03/06/2023 12:48, Arınç ÜNAL wrote:
> On 29.05.2023 16:40, Matthias Brugger wrote:
>>
>>
>> On 12/04/2023 19:06, Arınç ÜNAL wrote:
>>> On 12.04.2023 19:53, Frank Wunderlich wrote:
>>>> Hi
>>>>
>>>>> Gesendet: Mittwoch, 12. April 2023 um 18:21 Uhr
>>>>> Von: "Arınç ÜNAL" <arinc.unal at arinc9.com>
>>>>>> thanks, it changes the master when i upgrade iproute to 6.1 (from debian 
>>>>>> bullseye-backports), but i cannot do any traffic on it after switching to 
>>>>>> gmac1...
>>>>>>
>>>>>> 5: wan at eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue 
>>>>>> state UP group default qlen 1000
>>>>>>       link/ether f2:d2:51:56:cd:3d brd ff:ff:ff:ff:ff:ff
>>>>>>       inet 192.168.0.11/24 scope global wan
>>>>>>          valid_lft forever preferred_lft forever
>>>>>>
>>>>>> see no p5-TX/gmac-rx
>>>>
>>>>> Did you apply the vlan and flooding fix patches from Richard?
>>>>
>>>> have now applied all patches i've found from richard (which are all rejected):
>>>>
>>>> fe4495bb3cc2 2023-02-12 Fix setting up CPU and User ports to be in the 
>>>> correct mode during setup and when toggling vlan_filtering on a bridge 
>>>> port.  (HEAD -> 6.3-rc)
>>>> b0641f3e1a69 2023-02-12 Fix Flooding: Disable by default on User ports and 
>>>> Enable on CPU ports
>>>> cb04b3451524 2023-02-12 Do not add all User ports to the CPU by default. 
>>>> This will break Multi CPU when added a seperate patch. It will be 
>>>> overwritten by .port_enable and since we are forcing output to a port via 
>>>> the Special Tag this is not needed.
>>>>
>>>> and now it seems working and is clear ;)
>>>>
>>>> root at bpi-r2:~# ip l show wan
>>>> 5: wan at eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state 
>>>> UP mode DEFAULT group default qlen 1000
>>>>      link/ether f2:d2:51:56:cd:3d brd ff:ff:ff:ff:ff:ff
>>>>
>>>> iperf3
>>>> [ ID] Interval           Transfer     Bitrate         Retr
>>>> [  5]   0.00-10.00  sec  1.09 GBytes   940 Mbits/sec    0 sender
>>>> [  5]   0.00-10.03  sec  1.09 GBytes   936 Mbits/sec receiver
>>>>
>>>>
>>>> iperf3 -R
>>>> [ ID] Interval           Transfer     Bitrate         Retr
>>>> [  5]   0.00-10.04  sec  1.09 GBytes   936 Mbits/sec    0 sender
>>>> [  5]   0.00-10.00  sec  1.09 GBytes   938 Mbits/sec receiver
>>>>
>>>>
>>>> how do you deal with these patches? do you include them into your mt7530 
>>>> fixes series? they (and vladimirs preferred cpu-port) need to be applied 
>>>> before these DTS-changes
>>>
>>> Dealing with this is the last step on my tasklist. Take a look:
>>>
>>> https://arinc9.notion.site/mt7530-c-improvements-bbfdc2ceb958484b9627297b88bc6d4a
>>>
>>
>> I'm a bit lost here. @frank can this be merged now or are there still 
>> oustanding issues. It seems to me that not, but just in case...
> 
> I fixed the network connectivity issue on the MT7530 DSA sudriver which was the 
> main problem this patch series would cause. I don't see an issue that should 
> block this series anymore.
> 
> With the current MT7530 DSA sudriver, port 5 will be the active CPU port instead 
> of 6. I've got a patch series to prefer port 6 instead but in the meantime, this 
> patch series should be good to apply.
> 
> Arınç

Applied now, thanks!