[PATCH v3] media: platform: mtk-mdp3: Fix resource leak in mdp_get_subsys_id() and mdp_comp_config()

Lu Hongfei luhongfei at vivo.com
Fri Jul 21 03:40:47 PDT 2023


On 2023/7/21 17:41, Hans Verkuil Wrote:
> Hi Lu Hongfei,
>
> On 13/06/2023 05:27, Lu Hongfei wrote:
>> Add a put_device() call for the release of the object
>> which was determined by a of_find_device_by_node() call
>> in mdp_get_subsys_id().
>>
>> Add of_node_put() call for the release of the object
>> which was determined by a for_each_child_of_node() call
>> in mdp_comp_config().
>
> After merging this patch from you into our media_stage tree:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20230530101724.31412-1-luhongfei@vivo.com/
>
> this v3 no longer applies. So I will need a v4, I'm afraid...
>
> Regards,
>
> 	Hans

Hi Hans,

If you have merged this patch:  https://patchwork.linuxtv.org/project/linux-media/patch/20230530101724.31412-1-luhongfei@vivo.com/

I think it may not be necessary to merge into v3 because they both solve the same problem, which can simplify our work.

What do you think?

MBR,

Hongfei

>



More information about the Linux-mediatek mailing list