[PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node

Thierry Reding thierry.reding at gmail.com
Mon Jan 30 07:54:56 PST 2023


On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote:
> > Specify #pwm-cells on pwm at 11006000 to make it actually usable.
> > 
> > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index 146e18b5b1f4..f321c6d0fd7c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -435,6 +435,7 @@ uart3: serial at 11005000 {
> >  	pwm: pwm at 11006000 {
> >  		compatible = "mediatek,mt7622-pwm";
> >  		reg = <0 0x11006000 0 0x1000>;
> > +		#pwm-cells = <2>;
> 
> 3 should be possible, too. The driver does only support one
> polarity, so it's not really needed, but would be nice for consistency?
> 
> Thierry, what's your take here?

There's little point in setting this to 3 if the driver doesn't support
it. The core should catch misconfiguration, but that's more of a fail-
safe and if we can just avoid this from the start by not allowing anyone
to specify inversed polarity that seems like a good idea.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20230130/95a63ff7/attachment-0001.sig>


More information about the Linux-mediatek mailing list