[PATCH v2 05/13] mtd: devices: Replace all spi->chip_select and spi->cs_gpiod references with function call

Michal Simek michal.simek at amd.com
Mon Jan 23 04:47:24 PST 2023



On 1/19/23 19:53, Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra at amd.com>
> ---
>   drivers/mtd/devices/mtd_dataflash.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
> index 3bbaa590c768..1d3b2a94581f 100644
> --- a/drivers/mtd/devices/mtd_dataflash.c
> +++ b/drivers/mtd/devices/mtd_dataflash.c
> @@ -639,7 +639,7 @@ static int add_dataflash_otp(struct spi_device *spi, char *name, int nr_pages,
>   
>   	/* name must be usable with cmdlinepart */
>   	sprintf(priv->name, "spi%d.%d-%s",
> -			spi->master->bus_num, spi->chip_select,
> +			spi->master->bus_num, spi_get_chipselect(spi, 0),
>   			name);
>   
>   	device = &priv->mtd;


Reviewed-by: Michal Simek <michal.simek at amd.com>

Thanks,
Michal



More information about the Linux-mediatek mailing list