[PATCH net-next v3 01/11] net: mdio: Add dedicated C45 API to MDIO bus drivers
Paolo Abeni
pabeni at redhat.com
Tue Jan 10 04:49:28 PST 2023
On Tue, 2023-01-10 at 12:16 +0100, Paolo Abeni wrote:
> On Mon, 2023-01-09 at 16:30 +0100, Michael Walle wrote:
> > diff --git a/include/linux/phy.h b/include/linux/phy.h
> > index 6378c997ded5..65844f0a7fb3 100644
> > --- a/include/linux/phy.h
> > +++ b/include/linux/phy.h
> > @@ -364,6 +364,11 @@ struct mii_bus {
> > int (*read)(struct mii_bus *bus, int addr, int regnum);
> > /** @write: Perform a write transfer on the bus */
> > int (*write)(struct mii_bus *bus, int addr, int regnum, u16 val);
> > + /** @read: Perform a C45 read transfer on the bus */
>
> Minor nit: s/@read/@read_c45/
>
> > + int (*read_c45)(struct mii_bus *bus, int addr, int devnum, int regnum);
> > + /** @write: Perform a C45 write transfer on the bus */
>
> Mutatis mutandis, same thing here.
Otherwise the series LGTM. I think it would be preferable avoiding
reposting a largish series like this for such a minor change. I think
the series can be merged as-is and the above can be addressed with a
follow-up patch.
Cheers,
Paolo
More information about the Linux-mediatek
mailing list