[PATCH RFC net-next 4/4] net: mtk_eth_soc: note interface modes not set in supported_interfaces

Simon Horman simon.horman at corigine.com
Sat Feb 25 12:28:31 PST 2023


On Sat, Feb 25, 2023 at 07:11:44PM +0000, Russell King (Oracle) wrote:
> On Sat, Feb 25, 2023 at 05:49:18PM +0100, Simon Horman wrote:
> > On Fri, Feb 24, 2023 at 12:36:26PM +0000, Russell King (Oracle) wrote:
> > 
> > Hi Russell,
> > 
> > I think it would be good to add a patch description here.
> > 
> > Code change looks good to me.
> 
> As noted in the cover message, this is to highlight the issue to
> hopefully get folk to think what we should do about RMII and REVMII
> in this driver - basically, should we continue to support them, or
> remove it completely.
> 
> Either way, this patch won't hit net-next in its current form.
> 
> Essentially, the choice is either we remove these two switch cases,
> or we add these interface modes to the supported_interfaces array.
> 
> I'd rather those with mtk_eth_soc made the decision, even though it
> is highly unlikely that these modes are used on the hardware they
> have - as I don't have any mediatek hardware.
> 
> Thanks.

Thanks, understood.
Sorry for missing this earlier.



More information about the Linux-mediatek mailing list