[PATCH 1/2] wifi: mac80211: introduce ieee80211_refresh_tx_agg_session_timer()

Johannes Berg johannes at sipsolutions.net
Fri Feb 17 10:01:10 PST 2023


On Sat, 2023-02-18 at 01:50 +0800, Ryder Lee wrote:
> This allows low level drivers to refresh the tx agg session timer, based on
> querying stats from the firmware usually. Especially for some mt76 devices
> support .net_fill_forward_path would bypass mac80211, which leads to tx BA
> session timeout for certain clients.
> 

Does it even matter? We could just request sessions without a timeout in
the first place.

Or do you have a strong reason to need the timeout, such as limited
hardware resources for (TX) aggregation sessions?

But then maybe you should just time them out based on FW statistics
directly, rather than having to periodically refresh the timer in
mac80211?

I don't mind the patch, and I'll happily take it if it's needed, I'm
just wondering if that isn't a very roundabout way of achieving things.

johannes



More information about the Linux-mediatek mailing list