[PATCH] wifi: mt76: mt7915: unlock on error in mt7915_thermal_temp_store()

Lorenzo Bianconi lorenzo at kernel.org
Thu Feb 16 05:25:12 PST 2023


> Drop the lock before returning -EINVAL.
> 
> Fixes: ecaccdae7a7e ("wifi: mt76: mt7915: rework mt7915_thermal_temp_store()")
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>

> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> index 1ab768feccaa..728150b35537 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> @@ -89,6 +89,7 @@ static ssize_t mt7915_thermal_temp_store(struct device *dev,
>  	     val < phy->throttle_temp[MT7915_CRIT_TEMP_IDX])) {
>  		dev_err(phy->dev->mt76.dev,
>  			"temp1_max shall be greater than temp1_crit.");
> +		mutex_unlock(&phy->dev->mt76.mutex);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.39.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20230216/ecb4ab26/attachment.sig>


More information about the Linux-mediatek mailing list