[PATCH v3 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer

[Chunfeng Yun (云春峰)]

On Wed, 2023-12-20 at 06:57 +0100, Greg Kroah-Hartman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, Dec 20, 2023 at 10:58:41AM +0800, Chunfeng Yun wrote:
> > For Gen1 isoc-in transfer, host still send out unexpected ACK after
> device
> > finish the burst with a short packet, this will cause an exception
> on the
> > connected device, such as, a usb 4k camera.
> > It can be fixed by setting rxfifo depth less than 4k bytes, prefer
> to use
> > 3k here, the side-effect is that may cause performance drop about
> 10%,
> > including bulk transfer.
> > 
> > Fixes: 926d60ae64a6 ("usb: xhci-mtk: modify the SOF/ITP interval
> for mt8195")
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> > ---
> > v3:
> > add Cc stable
> 
> Why is a patch that you are marking for stable inclusion (and I am
> guessing inclusion in 6.7-final) in the middle of other patches that
> are
> not marked as such?
I'll remove Cc.

> 
> Always split out bugfixes from other things so that they can go
> through
> the two different branches, one for this current release, and one for
> the next one.
> 
> Otherwise you will have to wait until 6.8-rc1 for this bugfix to
> land,
> which I doubt you intend to have happen.
> 
> Please fix up and resend 2 different patch series.
Send v3 today, and modify property;

Thanks a lot
> 
> thanks,
> 
> greg k-h