[PATCH 2/2] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188

CK Hu (胡俊光) ck.hu at mediatek.com
Thu Dec 14 18:47:25 PST 2023


Hi, Jason:

On Fri, 2023-12-15 at 10:35 +0800, Jason-JH.Lin wrote:
> Add CMDQ driver support for mt8188 by adding its compatible and
> driver data in CMDQ driver.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin at mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 76e5f762628c..612b9feb258a 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -749,11 +749,19 @@ static const struct gce_plat gce_plat_v7 = {
>  	.gce_num = 1
>  };
>  
> +static const struct gce_plat gce_plat_v8 = {
> +	.thread_nr = 32,
> +	.shift = 3,
> +	.control_by_sw = true,
> +	.gce_num = 2
> +};
> +
>  static const struct of_device_id cmdq_of_ids[] = {
>  	{.compatible = "mediatek,mt6779-gce", .data = (void
> *)&gce_plat_v4},
>  	{.compatible = "mediatek,mt8173-gce", .data = (void
> *)&gce_plat_v2},
>  	{.compatible = "mediatek,mt8183-gce", .data = (void
> *)&gce_plat_v3},
>  	{.compatible = "mediatek,mt8186-gce", .data = (void
> *)&gce_plat_v7},
> +	{.compatible = "mediatek,mt8188-gce", .data = (void
> *)&gce_plat_v8},

I think 'v8' is not trivial for anyone. Every SoC has each setting, so
I would like the name to directly show the SoC name, such as
'gce_plat_mt8188'. So does other SoC.

Regards,
CK

>  	{.compatible = "mediatek,mt8192-gce", .data = (void
> *)&gce_plat_v5},
>  	{.compatible = "mediatek,mt8195-gce", .data = (void
> *)&gce_plat_v6},
>  	{}


More information about the Linux-mediatek mailing list