[v8 3/4] ASoC: mediatek: mt8188-mt6359: add es8326 support

Conor Dooley conor.dooley at microchip.com
Tue Dec 12 01:59:21 PST 2023


On Tue, Dec 12, 2023 at 10:38:20AM +0100, AngeloGioacchino Del Regno wrote:
> Il 12/12/23 05:04, Rui Zhou ha scritto:
> > Hi Angelo,
> > Because the TDM interface defined by mt8188_max98390_ops sets a fixed 4
> > slots, so if the current sound card only supports two amps, we need to skip
> > this setting.
> > By the way, do you think this comment is okay?
> > /*
> >   * The TDM protocol settings with fixed 4 slots are defined in
> >   * mt8188_max98390_ops. Two amps is I2S mode,
> >   * SOC and codec don't require TDM settings.
> > */
> > if (!(card_data->quirk & MAX98390_TWO_AMP)) {
> > dai_link->ops = &mt8188_max98390_ops;
> > }
> 
> That's perfect. Waiting for v9.

And please make sure that that v9 goes to the devicetree mailing list
and whatever other lists have been omitted in this submission.

Cheers,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20231212/82f8e769/attachment.sig>


More information about the Linux-mediatek mailing list