[PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to ethtool_puts()

[Wei Fang]

> -----Original Message-----
> From: justinstitt at google.com <justinstitt at google.com>
> Sent: 2023年12月7日 7:16
> To: David S. Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Shay Agroskin <shayagr at amazon.com>; Arthur
> Kiyanovski <akiyano at amazon.com>; David Arinzon
> <darinzon at amazon.com>; Noam Dagan <ndagan at amazon.com>; Saeed
> Bishara <saeedb at amazon.com>; Rasesh Mody <rmody at marvell.com>;
> Sudarsana Kalluru <skalluru at marvell.com>; GR-Linux-NIC-Dev at marvell.com;
> Dimitris Michailidis <dmichail at fungible.com>; Yisen Zhuang
> <yisen.zhuang at huawei.com>; Salil Mehta <salil.mehta at huawei.com>; Jesse
> Brandeburg <jesse.brandeburg at intel.com>; Tony Nguyen
> <anthony.l.nguyen at intel.com>; Louis Peens <louis.peens at corigine.com>;
> Shannon Nelson <shannon.nelson at amd.com>; Brett Creeley
> <brett.creeley at amd.com>; drivers at pensando.io; K. Y. Srinivasan
> <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>; Wei Liu
> <wei.liu at kernel.org>; Dexuan Cui <decui at microsoft.com>; Ronak Doshi
> <doshir at vmware.com>; VMware PV-Drivers Reviewers
> <pv-drivers at vmware.com>; Andy Whitcroft <apw at canonical.com>; Joe
> Perches <joe at perches.com>; Dwaipayan Ray <dwaipayanray1 at gmail.com>;
> Lukas Bulwahn <lukas.bulwahn at gmail.com>; Hauke Mehrtens
> <hauke at hauke-m.de>; Andrew Lunn <andrew at lunn.ch>; Florian Fainelli
> <f.fainelli at gmail.com>; Vladimir Oltean <olteanv at gmail.com>; Arınç ÜNAL
> <arinc.unal at arinc9.com>; Daniel Golle <daniel at makrotopia.org>; Landen
> Chao <Landen.Chao at mediatek.com>; DENG Qingfang <dqfext at gmail.com>;
> Sean Wang <sean.wang at mediatek.com>; Matthias Brugger
> <matthias.bgg at gmail.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno at collabora.com>; Linus Walleij
> <linus.walleij at linaro.org>; Alvin Šipraga <alsi at bang-olufsen.dk>; Wei Fang
> <wei.fang at nxp.com>; Shenwei Wang <shenwei.wang at nxp.com>; Clark
> Wang <xiaoning.wang at nxp.com>; dl-linux-imx <linux-imx at nxp.com>; Lars
> Povlsen <lars.povlsen at microchip.com>; Steen Hegelund
> <Steen.Hegelund at microchip.com>; Daniel Machon
> <daniel.machon at microchip.com>; UNGLinuxDriver at microchip.com; Jiawen
> Wu <jiawenwu at trustnetic.com>; Mengyuan Lou
> <mengyuanlou at net-swift.com>; Heiner Kallweit <hkallweit1 at gmail.com>;
> Russell King <linux at armlinux.org.uk>; Alexei Starovoitov <ast at kernel.org>;
> Daniel Borkmann <daniel at iogearbox.net>; Jesper Dangaard Brouer
> <hawk at kernel.org>; John Fastabend <john.fastabend at gmail.com>
> Cc: linux-kernel at vger.kernel.org; netdev at vger.kernel.org; Nick Desaulniers
> <ndesaulniers at google.com>; Nathan Chancellor <nathan at kernel.org>; Kees
> Cook <keescook at chromium.org>; intel-wired-lan at lists.osuosl.org;
> oss-drivers at corigine.com; linux-hyperv at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-mediatek at lists.infradead.org;
> bpf at vger.kernel.org; Justin Stitt <justinstitt at google.com>
> Subject: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to
> ethtool_puts()
> 
> This patch converts some basic cases of ethtool_sprintf() to ethtool_puts().
> 
> The conversions are used in cases where ethtool_sprintf() was being used
> with just two arguments:
> |       ethtool_sprintf(&data, buffer[i].name);
> or when it's used with format string: "%s"
> |       ethtool_sprintf(&data, "%s", buffer[i].name);
> which both now become:
> |       ethtool_puts(&data, buffer[i].name);
> 
> Signed-off-by: Justin Stitt <justinstitt at google.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c          |  4 +-
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index c3b7694a7485..bae9536de767 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2932,10 +2932,10 @@ static void fec_enet_get_strings(struct
> net_device *netdev,
>  	switch (stringset) {
>  	case ETH_SS_STATS:
>  		for (i = 0; i < ARRAY_SIZE(fec_stats); i++) {
> -			ethtool_sprintf(&data, "%s", fec_stats[i].name);
> +			ethtool_puts(&data, fec_stats[i].name);
>  		}
>  		for (i = 0; i < ARRAY_SIZE(fec_xdp_stat_strs); i++) {
> -			ethtool_sprintf(&data, "%s", fec_xdp_stat_strs[i]);
> +			ethtool_puts(&data, fec_xdp_stat_strs[i]);
>  		}
>  		page_pool_ethtool_stats_get_strings(data);
> 

Reviewed-by: Wei Fang <wei.fang at nxp.com>