[PATCH RESEND v4 2/2] drm/mediatek: Fix iommu fault during crtc enabling

Jason-JH Lin (林睿祥) Jason-JH.Lin at mediatek.com
Tue Aug 8 01:38:23 PDT 2023


Hi Alexandre,

On Mon, 2023-08-07 at 11:45 +0200, Alexandre Mergnat wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Hi Jason,
> 
> You forgot to put the Reviewed-by got from the V3 in your commit
> message.
> 

Since I changed the original method at the new version, I removed all
reviewed-by tags.
In order to avoid the version you have reviewed is too different.

Regards,
Jason-JH.Lin

> 
> On 07/08/2023 03:51, Jason-JH.Lin wrote:
> > The plane_state of drm_atomic_state is not sync to the
> mtk_plane_state
> > stored in mtk_crtc during crtc enabling.
> > 
> > So we need to update the mtk_plane_state stored in mtk_crtc by the
> > drm_atomic_state carried from mtk_drm_crtc_atomic_enable().
> > 
> > While updating mtk_plane_state, OVL layer should be disabled when
> the fb
> > in plane_state of drm_atomic_state is NULL.
> > 
> > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC
> MT8173.")
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin at mediatek.com>
> > ---
> > Change in RESEND v4:
> > Remove redundant plane_state assigning.
> > ---
> 
> 
> -- 
> Regards,
> Alexandre


More information about the Linux-mediatek mailing list