[PATCH v2 2/2] pwm: mediatek: Add support for MT7981
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Thu Apr 20 07:32:27 PDT 2023
Il 20/04/23 14:36, Daniel Golle ha scritto:
> The PWM unit on MT7981 uses different register offsets than previous
> MediaTek PWM units. Add support for these new offsets and add support
> for PWM on MT7981 which has 3 PWM channels, one of them is typically
> used for a temperature controlled fan.
>
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>
The implementation is good now; there's only one nitpick: you're reordering
the platform data entries and I agree about doing that, as they should be
alphabetically sorted, but you didn't mention that in the commit message.
Please send a v3 that mentions that you're also reordering.
"...while at it, also reorder..."
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
More information about the Linux-mediatek
mailing list