[PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr'
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Sep 23 11:15:59 PDT 2022
On 23/09/2022 20:14, Krzysztof Kozlowski wrote:
>> This is going to break MT2712e on old devicetrees.
>>
>> The right way of doing that is to check the return value of of_property_read_u32()
>> for "snps,clk-csr": if the property is not found, fall back to the old "clk_csr".
>
> I must admit - I don't care. That's the effect when submitter bypasses
> DT bindings review (81311c03ab4d ("net: ethernet: stmmac: add management
> of clk_csr property")).
>
> If anyone wants ABI, please document the properties.
>
> If out-of-tree users complain, please upstream your DTS or do not use
> undocumented features...
>
OTOH, as Angelo pointed out, handling old and new properties is quite
easy to achieve, so... :)
Best regards,
Krzysztof
More information about the Linux-mediatek
mailing list